UI review fixes: curve-drag perf, route intent, register cleanup#29
Closed
shiftedx wants to merge 17 commits into
Closed
UI review fixes: curve-drag perf, route intent, register cleanup#29shiftedx wants to merge 17 commits into
shiftedx wants to merge 17 commits into
Conversation
…malization Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d, audit catches camelCase Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ct-check naming Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s and Google Fonts import Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nd-address readout Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the P1–P2 findings from the 2026-06-11 design + performance critique of the reworked web UI (plan:
docs/superpowers/plans/2026-06-11-ui-review-fixes.md). Stacked onui-improvements(PR #28).Performance (the headline interaction: dragging a curve point with preview on)
snapshot—effectState.outputhas zero consumers (verified incl. the support bundle), yet the base-feel preview rewrote the snapshot every 35 ms, re-running ~60 snapshot-derived$:statements per tick. Same-session A/B: frame p95 26.3 ms → 16.7 ms (vsync floor).effectActivityUntil,effectStatusById(a prop of 5 panel instances), and the button-mapping session no longer rebuild with identical contents on every 1 Hz snapshot tick.web/scripts/curve-drag-budget.mjs(mutations/move + frame percentiles over a scripted 240-move drag). Note: absolute numbers are environment-sensitive; the wins above were measured as same-session A/Bs.Routing
Register / copy law
legacy*identifiers renamed (oldRouteRedirects,fallbackCopy,previous_soft_l2_trigger_curve_points— the Rust fn is internal-only, not serde-visible; needs this PR's CI for compile proof); source-audit pattern tightened to/legacy/iso camelCase can't evade it again.@importis gone (offline/LAN hang risk eliminated), and the Space Grotesk/Inter Tight remnants are deleted: the type system is now actually Inter-only (+ JetBrains Mono for literals). User-approved at checkpoint.Process
Every task was implemented by a fresh subagent and passed two-stage review (spec compliance, then code quality); review findings (drag-harness port leak, a stale-intent navigation race, a semantics-losing Rust rename) were fixed and re-reviewed before landing.
Full gate (
npm run check) green at every commit and at HEAD. The deferred P3 backlog (orphaneddualsense/focus/PNGs ~156 KB, rail typography, Edge-slots copy, Status desktop layout, emoji glyph, bottom-bar padding) is documented in.impeccable/critique/2026-06-11T05-34-28Z__web-src.md(local).🤖 Generated with Claude Code