add style, to readme. and also added the properties i just added of h… by Noitidart · Pull Request #31 · shimohq/react-native-prompt-android

Noitidart · 2018-02-22T23:20:57Z

…ighlightColor, placeholderColor, color, and disableFullScreenUI

Noitidart · 2018-03-09T05:48:43Z

Just added buttonColor option to change color of buttons. And also added cust to style so can change udnerline color, cursor color, and handle color. I also added to the readme on how to use this.

also color neutral button if its there. tested, if the button is not there, it doesnt crash, cool.

Noitidart · 2018-03-10T00:31:24Z

Fixes #25 (prop of disableFullscreenUI is added, and also in both cases (disableFullscreenUI true/false) the keyboard works) and survives orientation changes.

Noitidart · 2018-03-10T00:48:55Z

@greedbell this is ready to merge, may you please review.

wsong910 · 2018-03-12T02:45:26Z

android/src/main/java/im/shimo/react/prompt/RNPromptFragment.java

    }

+    @Override
+    public void onStart() {


why not put code after to line 113?

I wanted to. I actually tried to put it on line 91 - https://github.com/Noitidart/react-native-prompt-android/blob/dd428a864880209114ff9708f76e21e9d1937aa5/android/src/main/java/im/shimo/react/prompt/RNPromptFragment.java#L91 - where we initially work with postive button. However d.getButton returns null until after dialog shows. :(

This person here also encountered same issue - https://tassioauad.com/2016/06/02/dialogfragmentalertdialog-dismiss-automatically-on-click-button/

He says:

You will need to set this in the onResume() method because getButton() will return null until after the dialog has been shown! This should cause your custom action method to only be called once, and the dialog won’t be dismissed by default.

I also tried to ask on Stackoverflow, and other people have the same issue:

https://stackoverflow.com/questions/27520967/how-to-change-the-colour-of-positive-and-negative-button-in-custom-alert-dialog/27521470#comment85378535_27521470

@greedbell @wsong910 would you rather i make the change before accpeting PR? or would you like to find null cases and work around it?

wsong910 · 2018-03-12T03:03:21Z

android/src/main/java/im/shimo/react/prompt/RNPromptFragment.java

+            public void onShow(final DialogInterface dialog)
+            {
+                input.requestFocus();
+                ((InputMethodManager) alertDialog.getContext().getSystemService(Context.INPUT_METHOD_SERVICE)).showSoftInput(input, 0);


maybe below code behave better：
InputMethodManager imm = (InputMethodManager) alertDialog.getContext().getSystemService(Context.INPUT_METHOD_SERVICE);
if (imm != null) {
input.requestFocus();
imm.showSoftInput(view, 0);
}

Is there chance that imm is null? If it is, is there a way to wait for it to not be null? Because we always want to show keyboard.

@wsong910 - are you waiting on me to make this change before accepting this PR? Or are you researching when imm can be null so we can force get imm in that situation to ensure keyboard shows?

jeanregisser · 2018-03-13T13:36:04Z

README.md

+| defaultValue        | Default input value                                                               | String  |                                                      |
+| placeholder         |                                                                                   | String  |                                                      |
+| style               | `'default', 'shimo', 'cust'`                                                      | String  | 'default'                                            |
+| disableFullScreenUI | When in landscape mode, don't use fullscreen                                      | Boolean | false                                                |


Typo, should be disableFullscreenUI

Thanks very much for going through this and catching it. Fixing right now.

jeanregisser · 2018-03-13T15:03:42Z

android/src/main/java/im/shimo/react/prompt/RNPromptFragment.java

+    public void onStart() {
+        super.onStart();
+
+        if (!mButtonColor.isEmpty()) {


I just tested this and it crashes as mButtonColor is null when not specifying this prop or when passed an empty string.

In JS buttonColor: options.buttonColor || null will set buttonColor to null if not specified or if it's an empty string.

Oh shoot i forgot to test for null. Thanks so much on this right away.

fixed thanks @jeanregisser!

Noitidart · 2018-03-13T15:28:05Z

Added android-with-options screenshot to readme.

jeanregisser · 2018-03-13T15:34:25Z

README.md

- defaultValue         | Default input value                         |   String | ''
- placeholder          |                                             |   String | ''
+##### colorString
+Is one of the following: `'red', 'blue', 'green', 'black', 'white', 'gray', 'cyan', 'magenta', 'yellow', 'lightgray', 'darkgray', 'grey', 'lightgrey', 'darkgrey', 'aqua', 'fuchsia', 'lime', 'maroon', 'navy', 'olive', 'purple', 'silver', and 'teal'`


You could actually support the full color format (named, rgb, rgba, hsl, etc) available in React Native by processing the color passed to the components like this:

import processColor from 'react-native/Libraries/StyleSheet/processColor'; highlightColor: processColor(options.highlightColor), placeholderColor: processColor(options.placeholderColor), color: processColor(options.color), buttonColor: processColor(options.buttonColor)

Then just don't call Color.parseColor in Java but just take the Int value.

Oh sweet! Is it possible to process color on native side? Like RCTConvert in ios?

No, RCTConvert on iOS just transforms the int to a UIColor, so it can be conveniently used.
But Android native views can directly deal with Int.

Update to support full color format! Super awesome!! would be awesome to learn how to do this on native side too.

jeanregisser · 2018-03-13T15:48:12Z

android/src/main/java/im/shimo/react/prompt/RNPromptFragment.java

+
+        if (mButtonColor != null && !mButtonColor.isEmpty()) {
+            AlertDialog d = (AlertDialog) getDialog();
+            d.getButton(AlertDialog.BUTTON_POSITIVE).setTextColor(Color.parseColor(mButtonColor));


Since you now use processColor on the JS side, you need to remove all Color.parseColor and just take the Int value from the arguments.

jeanregisser · 2018-03-14T08:30:40Z

Tried your latest changes @Noitidart this works great! 👍

Noitidart · 2018-03-14T13:50:48Z

Super cool thanks @jeanregisser! :) I also learned a bunch thanks to you!

Noitidart · 2018-05-11T10:09:28Z

Bum, is there anything I need to do to get this accepted?

Noitidart added 13 commits February 22, 2018 15:20

add style, to readme. and also added the properties i just added of h…

97f27bf

…ighlightColor, placeholderColor, color, and disableFullScreenUI

Update RNPromptFragment.java

5d68e7f

Update RNPromptModule.java

4d870b7

RNPromptFragment.java updated for buttonColor and cust style name

9b16846

RNPromptModule.java update for buttonColor

f9ab93b

index.android.js for buttonColor

cddf659

Delete prompt_color.xml

8d4b760

Create colors.xml

97f5166

Update style.xml

51a4b24

Create cust_edit_text.xml

1dd31e5

how to use cust and also added buttonColor

7ee8ae5

Update index.android.js

1293f23

Update index.android.js

0a6c21b

Noitidart added 7 commits March 8, 2018 21:51

Update RNPromptFragment.java

9b13e6c

also color neutral button if its there. tested, if the button is not there, it doesnt crash, cool.

added manual linking instructions to readme

8a3b945

Update README.md

37f3e0c

Update README.md

aa95548

Update README.md

e8092ab

Fixes shimohq#24

a08841b

Fixes shimohq#26

dd428a8

greedbell assigned wsong910 Mar 10, 2018

wsong910 reviewed Mar 12, 2018

View reviewed changes

jeanregisser reviewed Mar 13, 2018

View reviewed changes

fix typo disableFullscreenUI

1aac796

jeanregisser reviewed Mar 13, 2018

View reviewed changes

allow null buttonColor

37ceddd

Noitidart added 3 commits March 13, 2018 08:24

add screenshot with android options

a3c1199

add screenshot to readme

a1ab4db

readme

3e2e89f

jeanregisser reviewed Mar 13, 2018

View reviewed changes

support the full color format (named, rgba, etc) thanks @jeanregisser!

47c5cba

jeanregisser reviewed Mar 13, 2018

View reviewed changes

remove Color.parseColor as we do processColor now

dcc7a0b

Noitidart mentioned this pull request Mar 13, 2018

Mention in readme that compileSdkVersion should be 25 cesardeazevedo/react-native-collapsing-toolbar#11

Closed

Noitidart added 2 commits March 13, 2018 10:08

swithced to Integer type for colors - tested and it compiles

515e307

better readme

e724872

Noitidart added 2 commits March 23, 2018 10:56

added android options of onDismiss and onAny - closes shimohq#34

88ea270

fixed readme typo highlightColor AARRGGBB to rgba

2f428e6

Conversation

Noitidart commented Feb 22, 2018

Uh oh!

Noitidart commented Mar 9, 2018

Uh oh!

Noitidart commented Mar 10, 2018

Uh oh!

Noitidart commented Mar 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Noitidart Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Noitidart commented Mar 13, 2018

Uh oh!

jeanregisser Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeanregisser commented Mar 14, 2018

Uh oh!

Noitidart commented Mar 14, 2018

Uh oh!

Noitidart commented May 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Noitidart Mar 12, 2018 •

edited

Loading

jeanregisser Mar 13, 2018 •

edited

Loading