Module gfx_screengrab#82
Open
X41 wants to merge 3 commits into
Open
Conversation
Member
|
I fixed your memory leak first. |
vifino
self-requested a review
April 6, 2019 17:22
vifino
approved these changes
Apr 6, 2019
| @@ -0,0 +1 @@ | |||
| -lX11 | |||
Member
There was a problem hiding this comment.
We needed the functions and such. Linker arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module grabs the top left corner of the screen and draws it to the LED matrix.
Not tested on real hardware yet and there seems to be some memory leak that makes the process blow up after a while, but in theory it should work just fine