Improve build metrics with new counters, gauges, and labels#2187
Open
avinal wants to merge 1 commit intoshipwright-io:mainfrom
Open
Improve build metrics with new counters, gauges, and labels#2187avinal wants to merge 1 commit intoshipwright-io:mainfrom
avinal wants to merge 1 commit intoshipwright-io:mainfrom
Conversation
openshift-ci
Bot
added
release-note
pull-request-size
Bot
added
the
size/XL
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Add build_buildrun_result_total counter that tracks BuildRun completions with outcome (succeeded/failed/cancelled/timeout), replacing the misleading build_buildruns_completed_total which fired at executor creation. Add build_buildrun_failure_reason_total counter for failure breakdown, build_buildruns_active gauge for in-flight BuildRuns, and build_buildstrategy_count gauge for strategy objects. Add opt-in labels strategy_kind, executor, result, and source_type to all metrics. Record pre-executor validation failures in result metrics. Count both successful and failed Build registrations. Fixes shipwright-io#2148 Assisted-by: Claude Code Signed-off-by: Avinal Kumar <avinal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add build_buildrun_result_total counter that tracks BuildRun completions
with outcome (succeeded/failed/cancelled/timeout), replacing the
misleading build_buildruns_completed_total which fired at executor
creation. Add build_buildrun_failure_reason_total counter for failure
breakdown, build_buildruns_active gauge for in-flight BuildRuns, and
build_buildstrategy_count gauge for strategy objects.
Add opt-in labels strategy_kind, executor, result, and source_type
to all metrics. Record pre-executor validation failures in result
metrics. Count both successful and failed Build registrations.
Related Issue
Fixes #2148
Type of PR
/kind feature
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes