Update dependencies for v0.19 release#375
Update dependencies for v0.19 release#375SaschaSchwarze0 merged 2 commits intoshipwright-io:mainfrom
Conversation
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
00c10d8 to
27b3547
Compare
There was a problem hiding this comment.
Pull request overview
Updates build and CI dependencies to newer versions, aligning the CLI with Shipwright Build v0.19.0 and newer Kubernetes/Tekton/Go toolchains.
Changes:
- Bump
github.com/shipwright-io/buildtov0.19.0and refresh Go/Kubernetes-related dependencies. - Update CI E2E matrix to Kubernetes
v1.33.7/v1.35.0and Tektonv1.9.1. - Update GitHub Action Go setup to use Go
1.25.x.
Reviewed changes
Copilot reviewed 3 out of 933 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Updates Go version directive and bumps direct/indirect dependencies (K8s, Shipwright Build, Tekton, etc.). |
| .github/workflows/e2e.yaml | Updates E2E test matrix Kubernetes versions and Kind/Tekton setup versions. |
| .github/actions/setup/action.yaml | Updates CI Go toolchain version used by the shared setup action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/shipwright-io/cli | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.6 |
There was a problem hiding this comment.
The go directive in go.mod must be a language version in major.minor form (e.g., 1.25), not a patch version like 1.25.6. Using a patch version can cause go mod parsing errors. If you want to pin an exact toolchain patch, keep go 1.25 and add/adjust a toolchain go1.25.6 directive instead.
| go 1.25.6 | |
| go 1.25 | |
| toolchain go1.25.6 |
There was a problem hiding this comment.
Seemingly not. If you change it to go 1.25 and then run go mod tidy, then it modifies to go 1.25.6.
| github.com/go-openapi/swag/cmdutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/conv v0.25.4 // indirect | ||
| github.com/go-openapi/swag/fileutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/jsonname v0.25.4 // indirect | ||
| github.com/go-openapi/swag/jsonutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/loading v0.25.4 // indirect | ||
| github.com/go-openapi/swag/mangling v0.25.4 // indirect | ||
| github.com/go-openapi/swag/netutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/stringutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/typeutils v0.25.4 // indirect | ||
| github.com/go-openapi/swag/yamlutils v0.25.4 // indirect |
There was a problem hiding this comment.
These entries look like package paths within the github.com/go-openapi/swag module rather than actual module paths. require directives must reference modules (i.e., paths containing their own go.mod), and if these subpaths are not real modules they will break go mod download/tidy. Recommend re-running go mod tidy (with the intended Go toolchain) and ensuring the dependency is expressed as the module root (github.com/go-openapi/swag v0.25.4) unless those subdirectories are verified submodules.
| github.com/go-openapi/swag/cmdutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/conv v0.25.4 // indirect | |
| github.com/go-openapi/swag/fileutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/jsonname v0.25.4 // indirect | |
| github.com/go-openapi/swag/jsonutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/loading v0.25.4 // indirect | |
| github.com/go-openapi/swag/mangling v0.25.4 // indirect | |
| github.com/go-openapi/swag/netutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/stringutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/typeutils v0.25.4 // indirect | |
| github.com/go-openapi/swag/yamlutils v0.25.4 // indirect |
There was a problem hiding this comment.
Remove them, run go mod tidy and they're back ...
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
087436c to
f51def3
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasanawad94, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This updates the build dependency to v0.19.0. Also updated are the Go version used in CI, and the tested Kubernetes and Tekton versions.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes