Skip to content

Update dependencies for v0.19 release#375

Merged
SaschaSchwarze0 merged 2 commits intoshipwright-io:mainfrom
SaschaSchwarze0:sascha-prepare-v0.19
Mar 3, 2026
Merged

Update dependencies for v0.19 release#375
SaschaSchwarze0 merged 2 commits intoshipwright-io:mainfrom
SaschaSchwarze0:sascha-prepare-v0.19

Conversation

@SaschaSchwarze0
Copy link
Copy Markdown
Member

Changes

This updates the build dependency to v0.19.0. Also updated are the Go version used in CI, and the tested Kubernetes and Tekton versions.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.19.0 milestone Mar 2, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 20:12
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Mar 2, 2026
@openshift-ci openshift-ci Bot requested review from hasanawad94 and qu1queee March 2, 2026 20:13
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates build and CI dependencies to newer versions, aligning the CLI with Shipwright Build v0.19.0 and newer Kubernetes/Tekton/Go toolchains.

Changes:

  • Bump github.com/shipwright-io/build to v0.19.0 and refresh Go/Kubernetes-related dependencies.
  • Update CI E2E matrix to Kubernetes v1.33.7 / v1.35.0 and Tekton v1.9.1.
  • Update GitHub Action Go setup to use Go 1.25.x.

Reviewed changes

Copilot reviewed 3 out of 933 changed files in this pull request and generated 2 comments.

File Description
go.mod Updates Go version directive and bumps direct/indirect dependencies (K8s, Shipwright Build, Tekton, etc.).
.github/workflows/e2e.yaml Updates E2E test matrix Kubernetes versions and Kind/Tekton setup versions.
.github/actions/setup/action.yaml Updates CI Go toolchain version used by the shared setup action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
module github.com/shipwright-io/cli

go 1.24.0
go 1.25.6
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go directive in go.mod must be a language version in major.minor form (e.g., 1.25), not a patch version like 1.25.6. Using a patch version can cause go mod parsing errors. If you want to pin an exact toolchain patch, keep go 1.25 and add/adjust a toolchain go1.25.6 directive instead.

Suggested change
go 1.25.6
go 1.25
toolchain go1.25.6

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemingly not. If you change it to go 1.25 and then run go mod tidy, then it modifies to go 1.25.6.

Comment thread go.mod
Comment on lines +56 to +66
github.com/go-openapi/swag/cmdutils v0.25.4 // indirect
github.com/go-openapi/swag/conv v0.25.4 // indirect
github.com/go-openapi/swag/fileutils v0.25.4 // indirect
github.com/go-openapi/swag/jsonname v0.25.4 // indirect
github.com/go-openapi/swag/jsonutils v0.25.4 // indirect
github.com/go-openapi/swag/loading v0.25.4 // indirect
github.com/go-openapi/swag/mangling v0.25.4 // indirect
github.com/go-openapi/swag/netutils v0.25.4 // indirect
github.com/go-openapi/swag/stringutils v0.25.4 // indirect
github.com/go-openapi/swag/typeutils v0.25.4 // indirect
github.com/go-openapi/swag/yamlutils v0.25.4 // indirect
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These entries look like package paths within the github.com/go-openapi/swag module rather than actual module paths. require directives must reference modules (i.e., paths containing their own go.mod), and if these subpaths are not real modules they will break go mod download/tidy. Recommend re-running go mod tidy (with the intended Go toolchain) and ensuring the dependency is expressed as the module root (github.com/go-openapi/swag v0.25.4) unless those subdirectories are verified submodules.

Suggested change
github.com/go-openapi/swag/cmdutils v0.25.4 // indirect
github.com/go-openapi/swag/conv v0.25.4 // indirect
github.com/go-openapi/swag/fileutils v0.25.4 // indirect
github.com/go-openapi/swag/jsonname v0.25.4 // indirect
github.com/go-openapi/swag/jsonutils v0.25.4 // indirect
github.com/go-openapi/swag/loading v0.25.4 // indirect
github.com/go-openapi/swag/mangling v0.25.4 // indirect
github.com/go-openapi/swag/netutils v0.25.4 // indirect
github.com/go-openapi/swag/stringutils v0.25.4 // indirect
github.com/go-openapi/swag/typeutils v0.25.4 // indirect
github.com/go-openapi/swag/yamlutils v0.25.4 // indirect

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove them, run go mod tidy and they're back ...

Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
@SaschaSchwarze0 SaschaSchwarze0 changed the title Update dependencies Update dependencies for v0.19 release Mar 2, 2026
Copy link
Copy Markdown
Contributor

@hasanawad94 hasanawad94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
/APPROVE

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@SaschaSchwarze0
Copy link
Copy Markdown
Member Author

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasanawad94, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@SaschaSchwarze0 SaschaSchwarze0 merged commit 7b8a563 into shipwright-io:main Mar 3, 2026
7 of 10 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-prepare-v0.19 branch March 3, 2026 07:48
@github-project-automation github-project-automation Bot moved this to Done in Issues Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants