Skip to content

feat: Mark SHIP-0040 as "Implemented"#296

Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
adambkaplan:ship-0040-implemented
Mar 4, 2026
Merged

feat: Mark SHIP-0040 as "Implemented"#296
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom
adambkaplan:ship-0040-implemented

Conversation

@adambkaplan
Copy link
Copy Markdown
Member

@adambkaplan adambkaplan commented Mar 3, 2026

Changes

Mark SHIP-0040 as "Implemented". Code changes released with v0.19.0

See #282

/kind documentation

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Mark SHIP-0040 as implemented, release with v0.19.0

Code changes released with v0.19.0

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@openshift-ci openshift-ci Bot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 3, 2026
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2026
@openshift-ci openshift-ci Bot requested review from HeavyWombat and qu1queee March 3, 2026 15:13
@adambkaplan
Copy link
Copy Markdown
Member Author

/assign @IrvingMg

Copy link
Copy Markdown
Member

@IrvingMg IrvingMg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
Copy link
Copy Markdown
Member Author

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Self-approving

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 37815e2 into shipwright-io:main Mar 4, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants