Removed multiArch object to place platforms directly inside output#305
Merged
openshift-merge-bot[bot] merged 1 commit intoshipwright-io:mainfrom Apr 21, 2026
Merged
Conversation
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
openshift-ci
Bot
added
the
kind/feature
pull-request-size
Bot
added
the
size/M
|
lgtm |
adambkaplan
approved these changes
Apr 21, 2026
Member
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
/lgtm
Matches our discussion last week.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As discussed in Monday's community meeting, I am hereby proposing to remove the
multiArchproperty inoutputin favor of puttingplatformsdirectly there. For this, I am seeing two reasons:multiArchmultiArchimplies multiple architecture. However, the concept can also be used to specify aplatformsarray with only one item with the goal to build exactly that platform within a Kubernetes cluster that has worker nodes with multiple platforms. This is more intuitive than asking such users to use thenodeSelector.Related Issue
Fixes #
Type of PR
/kind feature
Submitter Checklist
Release Notes