Put RaiseError middleware at the end of the middleware chain#45
Open
madejejej wants to merge 1 commit intoshlima:masterfrom
Open
Put RaiseError middleware at the end of the middleware chain#45madejejej wants to merge 1 commit intoshlima:masterfrom
madejejej wants to merge 1 commit intoshlima:masterfrom
Conversation
madejejej
force-pushed
the
proper-middleware-order
branch
from
a7f27b3 to
617ceb7
Compare
madejejej
changed the title
|
@shlima can you please take a look on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faraday middlewares are being called in reverse order.
With the current ordering, you might get a successful (200) response from Clickhouse with an expected content type (application/json), but the response body might contain an error message. This will cause ClickHouse to raise a
JSON::ParserErrororOj::ParserErrorinstead of aDbException.We need to reverse the middleware order to check the response status first and only then attempt to parse the body.