Open
Conversation
6495cbd to
4fde6e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a more interactive project create flow that can scaffold deployment/CI setup and initialize Git, while also refactoring composer.json generation and tightening GitLab code quality reporting output.
Changes:
- Refactor composer.json generation to a structured options-based builder (adds deployment/CI-related requirements and config).
- Extend
project createinto an interactive creator that can generate CI configs, deployment files, and optionally initialize a Git repo. - Ensure GitLab code quality JSON outputs an empty array (
[]) instead ofnullwhen there are no issues.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/validation/reporter.go | Emit [] for empty GitLab code quality issues list. |
| internal/system/symfony.go | Add helper to detect Symfony CLI presence. |
| internal/packagist/project_composer_json.go | Replace template-based composer.json generation with options + ordered JSON builder; add deployment-related requirements/config. |
| internal/packagist/project_composer_json_test.go | Update tests for new composer.json API and add deployment/feature coverage. |
| internal/git/git.go | Add git init helper wrapper. |
| cmd/project/project_create.go | Rework project create into interactive wizard; add flags; generate CI/deployment templates; optional git init; composer install refactor. |
| cmd/project/static/gitlab-ci.yml.tmpl | New GitLab CI template (optionally includes deploy stage for Deployer). |
| cmd/project/static/github-ci.yml | New GitHub Actions CI workflow template. |
| cmd/project/static/github-deploy.yml | New GitHub Actions deployment workflow template (Deployer). |
| cmd/project/static/deploy.php | New Deployer recipe template. |
Comments suppressed due to low confidence (1)
cmd/project/project_create.go:504
- Historically,
project createincluded Elasticsearch by default (the old--without-elasticsearchflag implied opt-out). With the new--with-elasticsearchdefaulting tofalse, new projects will omit Elasticsearch unless the user opts in, which is a breaking behavior change. If that’s not intended, keep the previous default (include Elasticsearch) and treat--with-elasticsearchas an alias/tri-state, or adjust defaults so existing behavior is preserved.
parsed := version.Must(version.NewVersion(release))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3f8c329 to
1d61acb
Compare
1d61acb to
491e6ba
Compare
8f0fdaf to
ec448cb
Compare
Resolved conflict in internal/extension/platform.go by keeping both: - The phpVersionURL variable (for testability) - The ctx parameter in NewRequestWithContext (for proper context propagation) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ec448cb to
f5a29d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on