SG-43838 [Coverage test] Uncovered function to validate advisory-only threshold#1110
Closed
stevelittlefish wants to merge 2 commits into
Closed
SG-43838 [Coverage test] Uncovered function to validate advisory-only threshold#1110stevelittlefish wants to merge 2 commits into
stevelittlefish wants to merge 2 commits into
Conversation
This function is intentionally not covered by tests. It exists solely to verify that the codecov.yml changes in the parent branch cause Codecov to report the miss as advisory-only rather than failing CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sg-43838/improve-codecov-config #1110 +/- ##
===================================================================
- Coverage 79.46% 79.46% -0.01%
===================================================================
Files 206 206
Lines 21007 21014 +7
===================================================================
+ Hits 16694 16698 +4
- Misses 4313 4316 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Adds str() coercion to format_version_range (7 executable lines) and tests for the open-ended and bounded-range paths, leaving only the ValueError branch uncovered. Expected patch coverage: 6/7 = 85.7%. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR exists purely to validate that the Codecov configuration changes in #1109 work as intended.
It adds
format_version_range()totank/util/version.py— a plausible but deliberately untested utility function. No tests cover it, so Codecov will report 0% patch coverage for the changed lines.What we expect to see
If CI is green on this PR despite the uncovered lines, the threshold config is working correctly.
What to check after CI runs
Jira: SG-43838
🤖 Generated with Claude Code