Skip to content

SG-44233 Remove stale Python 3.7 osutils binary#225

Open
stevelittlefish wants to merge 1 commit into
masterfrom
sg-44233-remove-py37-osutils
Open

SG-44233 Remove stale Python 3.7 osutils binary#225
stevelittlefish wants to merge 1 commit into
masterfrom
sg-44233-remove-py37-osutils

Conversation

@stevelittlefish

Copy link
Copy Markdown
Contributor

Summary

  • Removes osutils.cpython-37m-darwin.so from python/tk_desktop/extensions/darwin_python3/, alongside the still-present 3.9/3.10/3.11 builds.
  • SG-42559 (SG-42559 Load osutils from app bundle via sys.prefix #212) moved the primary load path to the app bundle via sys.prefix for SGD >= 3.0.0; this directory is only a fallback for SGD < 3.0.0, which never needed a Python 3.7 build removed here since nothing in the codebase references the file by name (Python's import machinery matches the ABI tag of the running interpreter automatically).

Test plan

  • grep -rn "cpython-37|37m-darwin" across the repo — no remaining references
  • No test in tests/ imports extensions/osutils directly
  • Manual verification on macOS with an old (<3.0.0) SGD build running Python 3.9+ recommended before merge, to confirm the fallback import still resolves correctly

Part of epic SG-36195.

🤖 Generated with Claude Code

darwin_python3/ still had osutils.cpython-37m-darwin.so committed
alongside the 3.9/3.10/3.11 builds. SG-42559 (#212) moved to loading
osutils from the app bundle via sys.prefix for SGD >= 3.0.0, and this
directory only serves as a fallback for SGD < 3.0.0 - neither path
needs a Python 3.7 build anymore.
@stevelittlefish
stevelittlefish requested a review from a team July 17, 2026 10:30
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.03%. Comparing base (c528bcc) to head (8adcab7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   24.03%   24.03%           
=======================================
  Files          70       70           
  Lines        4061     4061           
=======================================
  Hits          976      976           
  Misses       3085     3085           
Flag Coverage Δ
Linux 23.19% <ø> (ø)
Python-3.10 23.95% <ø> (ø)
Python-3.11 23.95% <ø> (ø)
Python-3.13 23.88% <ø> (-0.10%) ⬇️
Python-3.9 23.97% <ø> (ø)
Windows 23.41% <ø> (ø)
macOS 23.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants