SG-43798 Bump vendored tk-core to v0.23.10#159
Conversation
Runs tk_core_update.sh v0.23.10 to vendor the tk-core release that removes Python 3.7 support (SG-43667/#1107). This brings the version guard in python/tk-core/python/tank/__init__.py from a 3.7 hard-block to 3.9, and removes the vendored requirements/3.7/ directory. Note: v0.23.10 is currently a GitHub pre-release (QA in progress). tk_core_update.sh clones directly off the git tag and doesn't care about that flag, so this is safe to prep now, but this branch shouldn't be released until tk-core is confirmed/promoted. Scope intentionally excludes adding minimum_python_version to the top-level info.yml - that's tracked separately in SG-42460, which has its own history of breaking auto-update and needs its own careful validation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 10.30% 10.30%
=======================================
Files 13 13
Lines 582 582
=======================================
Hits 60 60
Misses 522 522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julien-lang
left a comment
julien-lang
left a comment
There was a problem hiding this comment.
Looks good but I don't see the changes from python-api?
Does this need to be resolved now? If so I can do another tk-core release but it's time consuming. |
It depends of the purpose of this release. If it's about releasing the 3.7 end of support, I believe we should include python-api. |
3 participants
Summary
Runs
tk_core_update.sh v0.23.10to vendor the tk-core release that removes Python 3.7 support (SG-43667 / tk-core#1107). This:python/tk-core/python/tank/__init__.pyfrom a Python 3.7 hard-block to 3.9.requirements/3.7/directory.Scope
Intentionally does not add
minimum_python_versionto the top-levelinfo.yml— that's tracked separately in SG-42460, which has its own revert history (PR #148 broke auto-update) and needs careful validation on its own.Test plan
python/tk-core/python/tank/__init__.pyguard now readssys.version_info < (3, 9)python/tk-core/requirements/3.7/is gonetankmodule on Python 3.9 - succeedsPart of epic SG-36195.
🤖 Generated with Claude Code