Skip to content

SG-43935 Update creation of dcc workfile (data model base)#149

Open
yungsiow wants to merge 2 commits into
masterfrom
ticket/sg-43935/data-model-create-update
Open

SG-43935 Update creation of dcc workfile (data model base)#149
yungsiow wants to merge 2 commits into
masterfrom
ticket/sg-43935/data-model-create-update

Conversation

@yungsiow

Copy link
Copy Markdown

NOTE: this branch will be treated as the base branch for publisher changes involving the Data Model project

  • add .flake8 copied from tk-core
  • add vim files to .gitignore
  • remove restrictions of single dcc workfile of same type per parent
  • add workfile type designation to workfile asset name
  • remove sg_task_name parameter
  • fix flake complaints

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.30%. Comparing base (feab3bc) to head (39deb9f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   18.30%   18.30%           
=======================================
  Files          32       32           
  Lines        3070     3070           
=======================================
  Hits          562      562           
  Misses       2508     2508           
Flag Coverage Δ
Linux 18.30% <ø> (ø)
Python-3.10 18.30% <ø> (ø)
Python-3.11 ?
Python-3.13 ?
Python-3.9 18.30% <ø> (ø)
Windows 18.30% <ø> (ø)
macOS 18.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

from __future__ import annotations

from typing import Any, Optional
from typing import Optional

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@carlos-villavicencio-adsk

carlos-villavicencio-adsk commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Let's rebase this branch with master to get the checkout revision fix

yungsiow added 2 commits July 16, 2026 12:37
- add .flake8 copied from tk-core
- add vim files to .gitignore
- remove restrictions of single dcc workfile of same type per parent
- add workfile type designation to workfile asset name
- remove sg_task_name parameter
- fix flake complaints
@yungsiow
yungsiow force-pushed the ticket/sg-43935/data-model-create-update branch from ee05846 to 39deb9f Compare July 16, 2026 16:37
@yungsiow

Copy link
Copy Markdown
Author

Let's rebase this branch with master to get the checkout revision fix

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants