fix(cli): record command forwards video.captureMode / video.jpegQuality#32
Open
jarkkosyrjala wants to merge 1 commit into
Open
Conversation
The `record` command's `record()` options object omits `captureMode` and `jpegQuality`, so setting them in `argo.config` has no effect on `argo record` — `record.ts` reads `options.captureMode` / `options.jpegQuality` (e.g. to select jpeg-stitch and the screencast JPEG quality), but the CLI never passes them, so they silently fall back to defaults (webm / quality 80-95). The `pipeline` command already forwards both from `config.video.*` (pipeline.ts); this makes `record` consistent. Symptom: `captureMode: 'jpeg-stitch'` + `jpegQuality: 100` in the config are ignored under `argo record`, so saturated-colour content keeps the default- quality JPEG screencast (visible per-frame flicker on anti-aliased edges).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
recordcommand silently ignoresvideo.captureModeandvideo.jpegQualityfrom the config.In
src/cli.ts, therecord(demo, { … })options object omits both fields:But
src/record.tsreads them offoptions:options.captureMode(record.ts:148→useJpegStitch = options.captureMode === 'jpeg-stitch')options.jpegQuality(record.ts:262→String(options.jpegQuality ?? defaultJpegQuality))So setting
captureMode: 'jpeg-stitch'and/orjpegQuality: 100inargo.confighas no effect underargo record— the recorder always falls back to the webm path and the default JPEG quality (80 at dsf>1 / 95). Thepipelinecommand is unaffected because it already forwards both (src/pipeline.ts:186-187,540-541):Symptom
I hit this while trying to raise screencast JPEG quality: on saturated-colour UI, the default quality-80 JPEG screencast produces visible per-frame flicker on anti-aliased edges (temporal noise the export can't remove).
captureMode: 'jpeg-stitch'+jpegQuality: 100fixes it — but only viapipeline, notrecord, until this change.Fix
Forward both fields in the
recordcommand's options, mirroringpipeline:Two lines. Both are already declared on
VideoConfig(src/config.ts:67,70) andRecordOptions(src/record.ts:28,30), so it's type-safe.tsc --noEmitpasses.Notes
v0.38.0/ currentmain.