Open
Conversation
shsa-odoo
reviewed
Feb 10, 2023
Comment on lines
+33
to
+44
| (x == computer_value) ? "" : "" ; | ||
|
|
||
| (x == 0 && computer_value== 1) ? computer++ : ""; | ||
| (x == 0 && computer_value== 2) ? me++ : ""; | ||
|
|
||
| (x == 1 && computer_value== 0) ? me++ : ""; | ||
| (x == 1 && computer_value== 2) ? computer++ : ""; | ||
|
|
||
|
|
||
| (x == 2 && computer_value== 0) ? computer++ : ""; | ||
| (x == 2 && computer_value== 1) ? me++ : ""; | ||
|
|
Owner
There was a problem hiding this comment.
avoid using repetitive code. here you can use nested ternary operator:
what i can see is there are only three cases when you can win:
you_win = ( (you === 0) && (opponent === 2) ||
(you === 1) && (opponent === 0) ||
(you === 2) && (opponent === 1) ) // returns true for your win cases only.
.
.
so (you === opponent) ? "draw message" : you_win ? you ++ : opponent++;
Author
There was a problem hiding this comment.
I will update my code sir . Thank you sir
shsa-odoo
reviewed
Feb 10, 2023
| </div> | ||
| </div> | ||
|
|
||
| <script type="text/javascript"> |
Owner
There was a problem hiding this comment.
Make a separate file for JS.
avoid putting your code to script tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a game created by me - temo