Open
Conversation
shsa-odoo
reviewed
Feb 10, 2023
Comment on lines
+19
to
+20
|
|
||
|
|
shsa-odoo
reviewed
Feb 10, 2023
Comment on lines
+10
to
+32
| if (str == comp_res) { | ||
| document.getElementById('result').innerHTML="Draw!"; | ||
| } | ||
| else if(str == 'rock' && comp_res == 'scissor') { | ||
| document.getElementById('result').innerHTML='You Won'; | ||
| user_score += 1; | ||
| document.getElementById('user_score_display').innerHTML=user_score; | ||
| } | ||
| else if(str == 'paper' && comp_res == 'rock') { | ||
| document.getElementById('result').innerHTML='You Won'; | ||
| user_score += 1; | ||
| document.getElementById('user_score_display').innerHTML=user_score; | ||
| } | ||
| else if(str == 'scissor' && comp_res == 'paper') { | ||
| document.getElementById('result').innerHTML="You Won"; | ||
| user_score += 1; | ||
| document.getElementById('user_score_display').innerHTML=user_score; | ||
| } | ||
| else { | ||
| document.getElementById('result').innerHTML='You Lose'; | ||
| comp_score += 1; | ||
| document.getElementById('comp_score_display').innerHTML=comp_score; | ||
| } |
Owner
There was a problem hiding this comment.
instead of multiple if..else statemets and repeating code section use concept of ternary operator:
what i can see is there are only three cases when user can win:
you_win = ( (you === "rock") && (opponent === "scissor") ||
(you === "paper") && (opponent === "rock") ||
(you === "scissor") && (opponent === "rock") ) // returns true for your win cases only.
.
.
so (you === opponent) ? "draw message" : you_win ? call a method for updating score and message for user : call method for updating score and message fro computer;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.