Convert Balancer and Provider to server components#36
Open
ooozo wants to merge 2 commits intoshuding:mainfrom
Open
Convert Balancer and Provider to server components#36ooozo wants to merge 2 commits intoshuding:mainfrom
ooozo wants to merge 2 commits intoshuding:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- `ScriptElement` renders the script only if it has not been rendered onto the DOM already. It does this by using the prop `isGlobal` and a serverside variable. This removes the need for React Context entirely - `Balancer` is now partially serverside, rendering its script and `ClientBalancer`. Any code that doesn't explicitly have to run on the client was moved to the server
Author
|
Should |
|
Any progress on this? Will be really helpful |
|
Cannot set a CSP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23
A large part of
react-wrap-balancercan run on the server. I've moved all code that strictly needs to run on the client toclient.ts. This allowed bothBalancerandProviderto be converted to server components. There are a few significant changes:RelayoutScriptis also rendered on the server and uses a local variable to determine if the relayout function has already been rendered at a global levelProvidercomponent only renders the relayout scriptClientBalancer(effects, relayout) and the rest stayed inBalancerto be rendered on the server