Fix: skip Balancer script if global one is already created#86
Open
mixeden wants to merge 1 commit intoshuding:mainfrom
Open
Fix: skip Balancer script if global one is already created#86mixeden wants to merge 1 commit intoshuding:mainfrom
mixeden wants to merge 1 commit intoshuding:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pacocoursey
reviewed
Mar 13, 2024
| if (!wrapper['__wrap_o']) { | ||
| if (typeof ResizeObserver !== 'undefined') { | ||
| ;(wrapper['__wrap_o'] = new ResizeObserver(() => { | ||
| ; (wrapper['__wrap_o'] = new ResizeObserver(() => { |
Collaborator
There was a problem hiding this comment.
Could you remove the miscellaneous changes in this PR? Like this whitespace.
pacocoursey
approved these changes
Mar 13, 2024
pacocoursey
requested changes
Mar 13, 2024
Comment on lines
+99
to
+101
| if (injected) { | ||
| return null | ||
| } |
Collaborator
There was a problem hiding this comment.
Actually no sorry this doesn't work at all… it's required to inject the script so that each instance of <Balancer /> is correctly balanced on SSR. Otherwise, you end up with this layout shift (on browsers that do not support text-wrap: balance, i.e. Safari)
ILUzvkAZ.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a great library, thanks for developing it :)
The problem I stumbled upon (and am fixing in this PR) is as follows.
There are two ways to use this library:
Now imagine you have a strict CSP and you need to pass a nonce. You pass the nonce to the Provider and do not pass it to Balancers.
This lib creates an empty script tag for each Balancer in case of global script injection. Since you don't pass the nonce to each Balancer, the CSP doesn't work (as there still is a script for each Balancer).
I fixed this by just not returning any script tag in case of global script injection.
Seems that this PR is associated with #78, but I'm not sure