Fix bug: OverflowError: mktime argument out of range#94
Open
samwellzuk wants to merge 1 commit intosibson:masterfrom
Open
Fix bug: OverflowError: mktime argument out of range#94samwellzuk wants to merge 1 commit intosibson:masterfrom
samwellzuk wants to merge 1 commit intosibson:masterfrom
Conversation
…t->_isdst->_time.mktime , raise a exception on windows: OverflowError: mktime argument out of range The min timestamp is 1970-1-1, considering timezone, if you are in east+8, 1970-1-1+8 turn into 0, so the best safe value is 1970-1-2
sibson
requested changes
Jul 12, 2018
Owner
sibson
left a comment
sibson
left a comment
There was a problem hiding this comment.
Seems reasonable. Could you take a look at the failing tests?
|
|
||
| return self.schedule.is_due(self.last_run_at or | ||
| datetime(MINYEAR, 1, 1, tzinfo=self.schedule.tz)) | ||
| datetime(1970, 1, 2, tzinfo=self.schedule.tz)) |
Owner
There was a problem hiding this comment.
Literal constants always set off alarms in my head but I don't see a good way to eliminate them in this case.
Owner
|
This has merge conflicts, once resolved I'll re-review. |
Owner
|
Conflicts need resolving and tests passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable use to call is_due->maybe_make_aware->is_navie->utcoffset->_isdst->_time.mktime
, raise a exception on windows: OverflowError: mktime argument out of range
The min timestamp is 1970-1-1, considering timezone, if you are in east+8, 1970-1-1+8 turn into 0,
so the best safe value is 1970-1-2