Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| return ( | ||
| <div className={`w-screen h-screen bg-transparent ${styles.electronDrag}`}> | ||
| <div className={`w-screen h-screen overflow-hidden bg-transparent ${styles.electronDrag}`}> |
There was a problem hiding this comment.
The PR description/motivation is specifically about preventing horizontal overflow/scrollbars, but overflow-hidden will clip both axes. Consider using overflow-x-hidden (and leaving Y as visible/auto as needed) to avoid accidentally clipping any vertical overflow (e.g., future popovers, shadows, or responsive layouts) while still addressing the horizontal scrollbar.
| <div className={`w-screen h-screen overflow-hidden bg-transparent ${styles.electronDrag}`}> | |
| <div className={`w-screen h-screen overflow-x-hidden bg-transparent ${styles.electronDrag}`}> |
|
|
||
| return ( | ||
| <div className={`w-screen h-screen bg-transparent ${styles.electronDrag}`}> | ||
| <div className={`w-screen h-screen overflow-hidden bg-transparent ${styles.electronDrag}`}> |
There was a problem hiding this comment.
The PR claims to fix issue #317, but the linked issue description refers to a horizontal scrollbar on an "issue creation page" near an "Assignees" sidebar, which doesn’t seem related to LaunchWindow. Please confirm the correct issue is linked (or update the PR description/issue reference) so the fix is traceable.
Description
Added
overflow-hiddento the rootdivcontainer of theLaunchWindowcomponent.Motivation
During hover interactions or UI transitions (such as expanding the Microphone or Webcam picker), layout recalculations and positioning boundaries were causing fractional width overflows beyond the 600px window bound. Because no overflow constraints were set, the Electron renderer was spawning a horizontal scrollbar. Enforcing
overflow-hiddenclips these visual artifacts and guarantees the scrollbar no longer appears.Type of Change
Related Issue(s)
Fixes #317
Summary by CodeRabbit