Skip to content

fix(i18n): add missing zh-CN translation for newRecording dialog#389

Open
richard950825-sys wants to merge 1 commit intosiddharthvaddem:mainfrom
richard950825-sys:fix/zh-CN-missing-newRecording-translation
Open

fix(i18n): add missing zh-CN translation for newRecording dialog#389
richard950825-sys wants to merge 1 commit intosiddharthvaddem:mainfrom
richard950825-sys:fix/zh-CN-missing-newRecording-translation

Conversation

@richard950825-sys
Copy link
Copy Markdown

@richard950825-sys richard950825-sys commented Apr 8, 2026

Summary

The zh-CN locale was missing the 'newRecording' section in editor.json, which exists in the en locale.

Changes

Added the following translations to src/i18n/locales/zh-CN/editor.json:

Key English Chinese
newRecording.title Return to Recorder 返回录屏
newRecording.description Your current session has been saved. 当前会话已保存。
newRecording.cancel Cancel 取消
newRecording.confirm Confirm 确认

Checklist

  • Translation is accurate and consistent with existing zh-CN style
  • JSON is valid

Summary by CodeRabbit

  • Localization
    • Added Chinese language support for the new recording feature, including translated strings for titles, descriptions, and action buttons.

The zh-CN locale was missing the 'newRecording' section in editor.json,
which is present in the en locale. This commit adds the translation for:
- title: 返回录屏
- description: 当前会话已保存。
- cancel: 取消
- confirm: 确认
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

Added a new newRecording localization section to the Chinese locale file with four translated strings: title, description, cancel, and confirm. Straightforward i18n addition, no existing translations modified.

Changes

Cohort / File(s) Summary
Localization strings
src/i18n/locales/zh-CN/editor.json
Added newRecording top-level key with four subkeys (title, description, cancel, confirm) for new recording feature UI strings in Chinese.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

📝✨ A recording awaits its voice,
Chinese whispers now have choice,
Four strings placed with careful hand,
Translation's magic, clean and grand!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding missing zh-CN translations for the newRecording dialog section.
Description check ✅ Passed The description covers the key points with a clear summary, detailed changes table, and a checklist, though it doesn't follow the full template structure with all sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/i18n/locales/zh-CN/editor.json (1)

2-7: other locales are also missing these keys

based on the context snippets, looks like es, fr, and tr locales are also missing the newRecording translations. they'll fall back to english when users select those languages, which is lowkey inconsistent.

not blocking for this PR since you're specifically fixing zh-CN, but worth addressing.

want me to help draft the same translations for the other missing locales (es, fr, tr)? could open an issue to track it if you'd prefer.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/i18n/locales/zh-CN/editor.json` around lines 2 - 7, The newRecording
translation object (keys: "newRecording" with "title", "description", "cancel",
"confirm") was added to zh-CN but is missing from other locale files (es, fr,
tr); add the same keys and translated values into the corresponding locale JSONs
(es, fr, tr) so they don't fall back to English—ensure each file defines
"newRecording": { "title": ..., "description": ..., "cancel": ..., "confirm":
... } with appropriate translations matching the zh-CN entries' intent;
optionally open an issue to track missing locale translations if you want
centralized follow-up.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/i18n/locales/zh-CN/editor.json`:
- Around line 2-7: The newRecording translation object (keys: "newRecording"
with "title", "description", "cancel", "confirm") was added to zh-CN but is
missing from other locale files (es, fr, tr); add the same keys and translated
values into the corresponding locale JSONs (es, fr, tr) so they don't fall back
to English—ensure each file defines "newRecording": { "title": ...,
"description": ..., "cancel": ..., "confirm": ... } with appropriate
translations matching the zh-CN entries' intent; optionally open an issue to
track missing locale translations if you want centralized follow-up.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 05b8bc15-723c-4f16-9067-bffcc7afcf8f

📥 Commits

Reviewing files that changed from the base of the PR and between e7d5f51 and 85bd215.

📒 Files selected for processing (1)
  • src/i18n/locales/zh-CN/editor.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants