fix(i18n): add missing zh-CN translation for newRecording dialog#389
Conversation
The zh-CN locale was missing the 'newRecording' section in editor.json, which is present in the en locale. This commit adds the translation for: - title: 返回录屏 - description: 当前会话已保存。 - cancel: 取消 - confirm: 确认
📝 WalkthroughWalkthroughAdded a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/i18n/locales/zh-CN/editor.json (1)
2-7: other locales are also missing these keysbased on the context snippets, looks like es, fr, and tr locales are also missing the newRecording translations. they'll fall back to english when users select those languages, which is lowkey inconsistent.
not blocking for this PR since you're specifically fixing zh-CN, but worth addressing.
want me to help draft the same translations for the other missing locales (es, fr, tr)? could open an issue to track it if you'd prefer.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/i18n/locales/zh-CN/editor.json` around lines 2 - 7, The newRecording translation object (keys: "newRecording" with "title", "description", "cancel", "confirm") was added to zh-CN but is missing from other locale files (es, fr, tr); add the same keys and translated values into the corresponding locale JSONs (es, fr, tr) so they don't fall back to English—ensure each file defines "newRecording": { "title": ..., "description": ..., "cancel": ..., "confirm": ... } with appropriate translations matching the zh-CN entries' intent; optionally open an issue to track missing locale translations if you want centralized follow-up.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/i18n/locales/zh-CN/editor.json`:
- Around line 2-7: The newRecording translation object (keys: "newRecording"
with "title", "description", "cancel", "confirm") was added to zh-CN but is
missing from other locale files (es, fr, tr); add the same keys and translated
values into the corresponding locale JSONs (es, fr, tr) so they don't fall back
to English—ensure each file defines "newRecording": { "title": ...,
"description": ..., "cancel": ..., "confirm": ... } with appropriate
translations matching the zh-CN entries' intent; optionally open an issue to
track missing locale translations if you want centralized follow-up.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 05b8bc15-723c-4f16-9067-bffcc7afcf8f
📒 Files selected for processing (1)
src/i18n/locales/zh-CN/editor.json
Summary
The zh-CN locale was missing the 'newRecording' section in
editor.json, which exists in the en locale.Changes
Added the following translations to
src/i18n/locales/zh-CN/editor.json:Checklist
Summary by CodeRabbit