Skip to content

fix(i18n): Update French translations for dialogs, editor, and settings#390

Open
FabLrc wants to merge 1 commit intosiddharthvaddem:mainfrom
FabLrc:update-french-translation
Open

fix(i18n): Update French translations for dialogs, editor, and settings#390
FabLrc wants to merge 1 commit intosiddharthvaddem:mainfrom
FabLrc:update-french-translation

Conversation

@FabLrc
Copy link
Copy Markdown
Contributor

@FabLrc FabLrc commented Apr 8, 2026

Description

Update French (fr) translations to match the current English baseline across all namespaces.

Motivation

Several translation keys were added or restructured in English but never reflected in the French locale, causing missing strings at runtime. This PR brings fr back in sync and adds it to the i18n validation script so it stays that way.

Type of Change

Other — i18n / Localization sync

Related Issue(s)

None

Screenshots / Video

N/A — text-only changes in JSON translation files.

Testing

Run the i18n check script:
node scripts/i18n-check.mjs
Verify no MISSING or EXTRA keys are reported for fr.

Checklist

[x] I have performed a self-review of my code.
[x] I have added any necessary screenshots or videos.
[x] I have linked related issue(s) and updated the changelog if applicable.

Summary by CodeRabbit

  • New Features

    • Enhanced French localization with new translations for recording dialogs, playback speed controls, and webcam customization options.
  • Chores

    • Expanded translation validation to include French language in automated consistency checks across all locales.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

PR adds French (fr) locale to the i18n validation pipeline and expands French translation coverage across dialogs, editor, and settings JSON files. The dialogs file restructures tutorial keys into segmented parts, while editor and settings files introduce new translation entries.

Changes

Cohort / File(s) Summary
Locale Validation
scripts/i18n-check.mjs
Added "fr" to COMPARE_LOCALES array, enabling French locale validation checks in the i18n comparison loop.
French Translation Files
src/i18n/locales/fr/dialogs.json, src/i18n/locales/fr/editor.json, src/i18n/locales/fr/settings.json
dialogs.json refactors tutorial translations (splits explanation/step1Description into before/middle/after segments); editor.json introduces newRecording block; settings.json adds customPlaybackSpeed, maxSpeedError, and webcamSize keys.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • siddharthvaddem

Poem

🇫🇷 french flows in, locale checks align,
dialog splits & settings shine—
two-am code that's lowkey fine,
validation script's got "fr" in line ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating French translations across multiple i18n files.
Description check ✅ Passed The description covers all essential template sections: what changed, why it matters, type of change, testing instructions, and completed checklist items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FabLrc FabLrc changed the title Update French translations for dialogs, editor, and settings fix(i18n): Update French translations for dialogs, editor, and settings Apr 8, 2026
@FabLrc
Copy link
Copy Markdown
Contributor Author

FabLrc commented Apr 8, 2026

Errors are not from this PR but already on main. This PR is safe

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
scripts/i18n-check.mjs (1)

4-4: nit: comment is slightly stale

the comment says "Compares zh-CN and es against the en baseline" but the array now includes fr and tr too. not a big deal but might confuse someone later.

📝 suggested fix
-* Compares zh-CN and es against the en baseline for every namespace.
+* Compares all configured locales against the en baseline for every namespace.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/i18n-check.mjs` at line 4, Update the stale top comment that reads
"Compares zh-CN and es against the en baseline" to accurately list all locales
currently being compared (e.g., "Compares zh-CN, es, fr and tr against the en
baseline"); locate the comment near the locales array (e.g., the variable named
locales or LOCALES in scripts/i18n-check.mjs) and change the text so it matches
the actual entries in that array.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/i18n-check.mjs`:
- Line 4: Update the stale top comment that reads "Compares zh-CN and es against
the en baseline" to accurately list all locales currently being compared (e.g.,
"Compares zh-CN, es, fr and tr against the en baseline"); locate the comment
near the locales array (e.g., the variable named locales or LOCALES in
scripts/i18n-check.mjs) and change the text so it matches the actual entries in
that array.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 981da419-8c40-4c8e-a372-3d5cb31f5399

📥 Commits

Reviewing files that changed from the base of the PR and between e7d5f51 and 8c0ce60.

📒 Files selected for processing (4)
  • scripts/i18n-check.mjs
  • src/i18n/locales/fr/dialogs.json
  • src/i18n/locales/fr/editor.json
  • src/i18n/locales/fr/settings.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant