refactor: centralize frontend orchestration and workspace lifecycle management#150
Open
vraj826 wants to merge 5 commits into
Open
refactor: centralize frontend orchestration and workspace lifecycle management#150vraj826 wants to merge 5 commits into
vraj826 wants to merge 5 commits into
Conversation
Contributor
Author
|
@siddu-k Can you review the changes made in this PR! |
Contributor
Author
|
@siddu-k Please review the changes! |
Owner
|
@vraj826 conflict |
Contributor
Author
|
@siddu-k Resolved the conflicts, now you can review! |
Contributor
Author
|
@siddu-k Branch was deleted locally from my forked repo by mistake, I have restored it, now the changes for it can be reviewed. |
Contributor
Author
|
@siddu-k I've resolved the conflicts. |
Contributor
Author
|
@siddu-k Any updates?! |
Contributor
Author
|
@siddu-k I have again resolved the conflicts, can you review it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #111
Fixes this issue
This PR stabilizes DevShell’s growing frontend orchestration layer by reducing duplicated async logic, centralizing modal/event lifecycle handling, and improving workspace/session synchronization flows.
It addresses issues around:
Changes made
Added lightweight shared frontend helpers for:
Consolidated duplicated logic for:
Reused a unified terminal builder across:
Centralized modal lifecycle management and overlay close handling
Stabilized workspace restore actions to avoid duplicate listeners
Improved terminal/workspace synchronization
Removed duplicated lifecycle cleanup blocks
Testing and validation
Tested:
Validation:
node --check ui/app.jspassedScreenshots and logs
Workspace recovery orchestration
Checklist
main