Fix: ensure temp file created during script instrumentation is always cleaned up#197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fixes a temp-file leak when script instrumentation creates a temporary file but writing to it fails. The code now tracks the created temp path and always passes that path into cleanup so orphaned
.tmp_run_*.shfiles are removed on error/finally paths.tempfile.mkstemp()and assignsrun_path = temp_pathonly on successful write; if the write fails the code falls back tofull_pathand the created temp file can be left on disk.temp_path_createdwhen a temp file is created and pass it to_cleanup_execution()(used on error paths and infinally) so the temp file is unlinked regardless ofrun_pathreassignment.How to test locally
.tmp_run_*.shfiles remain after the run or error path.closes Issue #196