Remove duplicate terminal session functions#210
Open
kunal-9090 wants to merge 3 commits into
Open
Conversation
Owner
|
@kunal-9090 can u fix the conflit |
Contributor
Author
|
Hi @siddu-k, the conflict has been fixed and the branch is updated. Current PR state is mergeable, and CI is green:\n\n- Python Tests & Security: success\n- Node.js Security & Linting: success\n\nPlease review/merge when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue\nFixes #170\n\n## GSSoC labels/level\n- gssoc:approved\n- level:advanced\n\n## Summary\n- Removed the duplicate terminal/session function block from ui/app.js.\n- Kept one implementation each for clearCli, saveSession, generateUUID, saveSessionDebounced, and restoreSession.\n- Preserved the terminal utility helper functions between the session block and terminal tab logic.\n\n## Validation\n- node --check ui/app.js