I3IpcClient "connect" emit order is corrected.#11
Open
ndvtr wants to merge 1 commit intosidorares:masterfrom
Open
I3IpcClient "connect" emit order is corrected.#11ndvtr wants to merge 1 commit intosidorares:masterfrom
ndvtr wants to merge 1 commit intosidorares:masterfrom
Conversation
I3IpcClient "connect" event emit is placed after "self._stream" assign.
Owner
|
why this was a problem? Does any code outside relies on |
Author
|
yes, you are right, |
Owner
|
can you elaborate why? Maybe we need to add public api for that? |
Author
|
Close/destroy socket connection after a timeout: I'm waiting a window event but not longer than 30 seconds or another logic, for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I3IpcClient "connect" event emit is placed after "self._stream" assign.