Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the List Item component, including its documentation, SCSS styles, and interactive examples. The feedback highlights several areas for improvement: removing placeholder suffixes in documentation headings, increasing CSS selector specificity in the theme styles, and adhering to UX writing guidelines regarding timestamp vocabulary, telegram-style descriptions, button placement, and label capitalization.
c072124 to
8d5328e
Compare
|
@spike-rabbit could you take a look at the example and provide some initial feedback if the structure looks as expected? |
panch1739
left a comment
There was a problem hiding this comment.
@ljanner Looks great!
Just one observation...in the list-item-actions, the active/selected state seems to be missing. When the list item is pressed, the background color should change to base-1-selected.
Questions:
- The replacement of the notification item would happen in another PR?
- Does this have the "unread" property also? (This is only valid for notification item)
f64852f to
7ab5d4b
Compare
I now added a new example called list-item-unread. While an unread state isn't quite generic I do think it makes sense to provide it since the idea is to drop the notification item entirely.
For the replacement itself, we need to choose a technical solution either:
This is still open, we can see how far we can get with migrations for element v50. For now I added a banner on the notification item docs recommending list-item instead. |
@ljanner Excellent! Is good for me :) Thank you very much! |
Resolves #1641
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: