feat(charts): Improve accessibility with keyboard interaction#1964
Draft
akashsonune wants to merge 1 commit intomainfrom
Draft
feat(charts): Improve accessibility with keyboard interaction#1964akashsonune wants to merge 1 commit intomainfrom
akashsonune wants to merge 1 commit intomainfrom
Conversation
b356d7e to
2edee9c
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements accessibility features for charts, including keyboard navigation for data points, zoom sliders, and legends, as well as ARIA support and live announcements. The review feedback identifies several TypeScript style guide violations regarding the use of the any type and suggests improvements for ARIA label redundancy and legend navigation logic.
1778050 to
e3e5eba
Compare
83b4548 to
c311421
Compare
Member
c311421 to
21eb1b1
Compare
Member
Author
21eb1b1 to
790fd7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escapeto close tooltipShift +/-Shift arrowshometo operate zoom sliderDocumentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: