feat(navbar-vertical-next): add alwaysOpenGroupsInFlyout mode#1971
feat(navbar-vertical-next): add alwaysOpenGroupsInFlyout mode#1971mistrykaran91 wants to merge 1 commit intomainfrom
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to the vertical navbar allowing item groups to always open as flyout panels via the alwaysOpenGroupsInFlyout input. The implementation includes hover-based opening and closing with a delay, updated styling for dropdown items, and a new example page. Feedback focuses on ensuring proper resource cleanup by implementing OnDestroy to clear timers and subscriptions, and improving test reliability by using fake timers to validate the hover-close delay logic.
mistrykaran91
force-pushed
the
feat/add-always-open-groups-in-flyout-mode
branch
2 times, most recently
from
30805a5 to
52f6dd4
Compare
mistrykaran91
force-pushed
the
feat/add-always-open-groups-in-flyout-mode
branch
from
724c89b to
25a0a55
Compare
- Add `alwaysOpenGroupsInFlyout` input to open groups as flyout panels on click, regardless of collapsed state - Switch caret icon from down to right when flyout mode is active Closes #1944
mistrykaran91
force-pushed
the
feat/add-always-open-groups-in-flyout-mode
branch
from
ebcb340 to
1b75512
Compare
|
@mistrykaran91 awesome! Just one thing...it would be nice if we can try to implement the responsive behavior as in Figma specs. Probably this part got lost in all the specs notes: 
There is also a rough proto :) |
3 participants
alwaysOpenGroupsInFlyoutinput to open groups as flyout panels on click, regardless of collapsed stateCloses #1944
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: