refactor(schematics): clear migration data for class members, components, elements, and symbols#1976
refactor(schematics): clear migration data for class members, components, elements, and symbols#1976mistrykaran91 wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request clears all migration data arrays for version 49, including class member replacements, component property names, element class changes, element selectors, symbol removals, and symbol renaming. The feedback indicates that emptying these arrays while the migration schematic is active will disable automated updates, leading to breaking changes and compilation errors for users. Specifically, the removal of symbol renaming and element selector transformations will force manual updates, undermining the purpose of the migration schematics.
| propertyReplacements: [{ property: 'initialState', replacement: '${expression}.inputValues' }] | ||
| } | ||
| ]; | ||
| export const CLASS_MEMBER_REPLACEMENTS_MIGRATION: ClassMemberReplacementInstruction[] = []; |
There was a problem hiding this comment.
Clearing the migration data while the migration-v49 schematic remains active in migration.json effectively disables all automated updates for this version. This action will result in breaking changes for users performing an ng update, as the expected transformations (such as property renamings and class member replacements) will not be applied. If these migrations are being moved to a different version or a new mechanism, please ensure that the update path remains intact for users transitioning to v49.
| ] | ||
| } | ||
| ]; | ||
| export const SYMBOL_RENAMING_MIGRATION: SymbolRenamingInstruction[] = []; |
There was a problem hiding this comment.
Removing the symbol renaming data is particularly impactful as it includes the migration from Simpl prefixed symbols to Si (e.g., SimplChartsNgModule to SiChartsNgModule). Without this data, users updating to v49 will encounter numerous compilation errors that would otherwise be handled automatically by the schematic.
| ] | ||
| } | ||
| ]; | ||
| export const ELEMENT_SELECTORS_MIGRATION: ElementSelectorInstruction[] = []; |
There was a problem hiding this comment.
Clearing this array removes the automatic migration of deprecated element selectors, such as si-unauthorized-page to si-info-page. This will require users to manually update their templates, which contradicts the purpose of the provided migration schematic.
spike-rabbit
added
the
breaking-changes
…nts, elements, and symbols
mistrykaran91
force-pushed
the
refactor/clean-up-schematics-data
branch
from
e54611b to
4f381d6
Compare
2 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: