test(content-action-bar): verify content-action-bar responsive behavi…#1977
test(content-action-bar): verify content-action-bar responsive behavi…#1977
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new responsive behavior test for the dashboard card component and updates its template to default to an expanded action bar view. Corresponding visual snapshots have been updated to reflect these changes. Feedback was provided to improve test robustness by using semantic ARIA roles for element locators instead of generic selectors.
spliffone
force-pushed
the
test/test-content-action-bar-responsives
branch
2 times, most recently
from
75132a4 to
47d58d8
Compare
|
|
||
| test.describe('si-content-action-bar-states', () => { | ||
| const example = 'si-content-action-bar/si-content-action-bar-states'; | ||
| const exampleDashboard = 'si-dashboard/si-dashboard-card'; |
There was a problem hiding this comment.
why test this in the dashboard example instead of using the above example that is for the content-action-bar only?
There was a problem hiding this comment.
Because the content action bar states example does include the required configuration. Shall create a specific si-content-action-bar or si-dashboard-card spec?
There was a problem hiding this comment.
what configuration is that? we have 3 expanded c-a-b that collapse when viewport gets smaller 🤷
So if something is missing, expand the example. It's super weird to have a si-content-action-bar-states.spec.ts that uses a whole different example
spliffone
force-pushed
the
test/test-content-action-bar-responsives
branch
from
47d58d8 to
d30c98b
Compare
3 participants
…our in e2e test
Add E2E test to verify the responsive behaviour of the content action bar
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: