fix(date-range-filter): show a label instead of ? when range is not defined#1989
Open
fix(date-range-filter): show a label instead of ? when range is not defined#1989
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a selectRangeLabel input to the SiDateRangeFilterComponent, enabling custom placeholder text when a date range is undefined. The templates are updated to use this label with text-secondary styling. Review feedback highlights that the translation key SI_DATE_RANGE_FILTER.SELECT_RANGE_Label violates the SCREAMING_SNAKE_CASE naming convention and contains a redundant suffix; suggestions were made to rename it to SI_DATE_RANGE_FILTER.SELECT_RANGE for consistency.
dr-itz
force-pushed
the
fix/date-range-filter/select-range-label
branch
from
d3373a9 to
df2725c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: