Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the @siemens-ux/design-tokens and @simpl/brand dependencies in package.json. Feedback was provided to correct the PR title's commit type from docs to build, as required by the repository style guide for dependency updates.
Comment on lines
+183
to
+184
| "@siemens-ux/design-tokens": "^0.4.1", | ||
| "@simpl/brand": "3.2.0", |
Contributor
There was a problem hiding this comment.
The PR title uses the docs commit type, which is reserved for documentation-only changes. Since this PR updates external dependencies, it should use the build type instead, as specified in the repository style guide (line 211). Consider using a scope like theme for better categorization (e.g., build(theme): update brand theme and tokens).
References
- Dependency changes must use the 'build' type as per the allowed types in the commit message format. (link)
spike-rabbit
requested changes
May 4, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Please squash your commits.
timowolf
force-pushed
the
docs/update-brand-theme
branch
from
9fae6a4 to
776bc8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: