Feat/tooltip/configure scroll strategy#1998
Merged
chintankavathia merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom CDK scroll strategies in popover and tooltip components by updating the overlay helper and respective directives and services. Feedback highlights a potential memory leak in the popover directive due to missing overlay disposal and suggests adding SSR safety checks. Furthermore, several newly added test components require the OnPush change detection strategy to align with the project's style guide.
spike-rabbit
force-pushed
the
feat/tooltip/configure-scroll-strategy
branch
4 times, most recently
from
089982e to
ad2bd40
Compare
chintankavathia
requested changes
May 5, 2026
spike-rabbit
force-pushed
the
feat/tooltip/configure-scroll-strategy
branch
2 times, most recently
from
71eb5ee to
9a644a0
Compare
Allows consumer to define a `ScrollStrategy` for the tooltip overlay.
Allows consumer to define a `ScrollStrategy` for the popover overlay.
spike-rabbit
force-pushed
the
feat/tooltip/configure-scroll-strategy
branch
from
9a644a0 to
43232c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows configuring the
scrollStrategyfor tooltips and popover.This follows the same approach we already have in the typeahead.
Closes https://code.siemens.com/simpl/simpl-element/-/work_items/2703
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: