chore(dashboards-demo): add native web component widget to showcase framework-agnostic integration#2007
Draft
chintankavathia wants to merge 1 commit intomainfrom
Draft
chore(dashboards-demo): add native web component widget to showcase framework-agnostic integration#2007chintankavathia wants to merge 1 commit intomainfrom
chintankavathia wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
chintankavathia
force-pushed
the
demo/dashboards/native-webcomponents
branch
from
98da873 to
b6e86e7
Compare
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a framework-agnostic native web component widget and its editor to the dashboard demo. The review feedback identifies a potential runtime error in the widget's setter and highlights several violations of the UX writing guidelines, specifically regarding capitalization, the use of trailing full stops, and direct user address in UI strings.
…ramework-agnostic integration Add `native-note-widget` and `native-note-widget-editor` as vanilla custom elements. Registered in the flexible dashboard widget catalog alongside existing Angular-based web component widgets.
chintankavathia
force-pushed
the
demo/dashboards/native-webcomponents
branch
from
b6e86e7 to
e2fd0ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
native-note-widgetandnative-note-widget-editoras vanilla custom elements. Registered in the flexible dashboard widget catalog alongside existing Angular-based web component widgets.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: