Conversation
spike-rabbit
force-pushed
the
feat/file-uploader-error-file-size-exceeded-param
branch
from
50620b2 to
9331f02
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic parameters for file upload error messages, allowing the maximum file size to be displayed to users. It adds an errorParams property to the UploadFile model and updates the translation pipe in the template. A review comment identifies that while the JSDoc for the errorTextFileMaxSize input in the file upload directive was updated, the actual implementation still uses the old static string, which will prevent the parameter from being displayed.
spike-rabbit
force-pushed
the
feat/file-uploader-error-file-size-exceeded-param
branch
3 times, most recently
from
d4c3a0a to
9b05256
Compare
… file size
The error message when a file exceeds the maximum file size now displays the
actual configured limit using the {{maxFileSize}} interpolation parameter.
Closes #2008
spike-rabbit
force-pushed
the
feat/file-uploader-error-file-size-exceeded-param
branch
from
9b05256 to
af4eff6
Compare
spliffone
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{maxFileSize}}interpolation parameter toSI_FILE_UPLOADER.ERROR_FILE_SIZE_EXCEEDEDtranslation stringMAX_SIZE,ACCEPTED_FILE_TYPES,MAX_FILE_REACHED) added in Add params to translation texts #1447UploadFilemodel witherrorParamsto carry translation parameters to the templateCloses #2008
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: