feat(search-bar): add maxlength input to limit search input length#2017
Merged
feat(search-bar): add maxlength input to limit search input length#2017
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a maxlength input to the SiSearchBarComponent and binds it to the underlying input element. Feedback suggests using the numberAttribute transform for the new input to ensure consistent type handling and requires the addition of unit tests to verify the functional change as per the repository style guide.
spike-rabbit
force-pushed
the
feat-search-bar-add-maxlength-input
branch
from
27d0179 to
f0c9e09
Compare
Adds a maxlength input to the SiSearchBarComponent that allows consumers to define the maximum length of the search input field.
spike-rabbit
force-pushed
the
feat-search-bar-add-maxlength-input
branch
from
f0c9e09 to
94aa47e
Compare
spliffone
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a maxlength input to the SiSearchBarComponent that allows consumers to define the maximum length of the search input field.
See https://code.siemens.com/simpl/simpl-element/-/work_items/2647
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: