refactor(map): use relative units for si-map controls#2019
Open
refactor(map): use relative units for si-map controls#2019
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the si-map component's SCSS by converting button dimensions from pixels to rems and utilizing the calc() function for layout properties. Feedback was provided regarding a potential layout shift and the importance of using calc() when mixing units for proper browser resolution.
dr-itz
requested changes
May 6, 2026
spliffone
force-pushed
the
feat/map-relative-sizing
branch
2 times, most recently
from
dae0428 to
8dd93b6
Compare
spliffone
force-pushed
the
feat/map-relative-sizing
branch
2 times, most recently
from
7fb327b to
fadd066
Compare
spliffone
force-pushed
the
feat/map-relative-sizing
branch
from
840f3f0 to
40f1521
Compare
Member
Author
|
@dr-itz Are we certain we want to shrink the button icons? |
Member
@panch1739 For map controls, what should icon size be? The 1.25rem/20px we have everywhere now or do we stay at 1.5rem/24px? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://code.siemens.com/simpl/simpl-element/-/work_items/4
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: