refactor(select): extract overflow-item style to theme#2020
Draft
spike-rabbit wants to merge 1 commit intomainfrom
Draft
refactor(select): extract overflow-item style to theme#2020spike-rabbit wants to merge 1 commit intomainfrom
spike-rabbit wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the custom .overflow-item styling in the select input with a new global .pill-sm utility class. Feedback indicates that the .overflow-item class must be retained as a marker because the component's test harness relies on it to locate the overflow counter.
spike-rabbit
force-pushed
the
refactor/move-overflow-item-to-theme
branch
4 times, most recently
from
b62ff3e to
c7d857e
Compare
The overflow item is a pill, just with `padding-block: 0`.
spike-rabbit
force-pushed
the
refactor/move-overflow-item-to-theme
branch
from
e2cc582 to
50441ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(select): use pill for overflow item
The overflow item is a pill, just with
padding-block: 0.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: