fix(forms): maintain hover/focus state with sibling form-control-actions#2024
Open
spike-rabbit wants to merge 1 commit intomainfrom
Open
fix(forms): maintain hover/focus state with sibling form-control-actions#2024spike-rabbit wants to merge 1 commit intomainfrom
spike-rabbit wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces E2E tests and visual snapshots for the si-datepicker calendar button's focus and hover states. It also updates the form control and validation SCSS to handle interaction states when sibling actions are hovered or focused using the :has() pseudo-class. Feedback focused on refining these selectors to exclude disabled or readonly states and ensuring consistent focus behavior within validation groups.
spike-rabbit
force-pushed
the
fix/form-control/keep-hover-actions
branch
2 times, most recently
from
d14a0d4 to
8d65e97
Compare
Previously, when hovering/focusing form-control-actions that where a sibling, the hover/focus state was removed from the input. With this change, it sticks except for the focus ring.
spike-rabbit
force-pushed
the
fix/form-control/keep-hover-actions
branch
from
8d65e97 to
68585cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when hovering/focusing form-control-actions that where a sibling, the hover/focus state was removed from the input.
With this change, it sticks except for the focus ring.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: