fix(core/select): Make disabled prop work for select items #IX-4149#241
Open
dmytro-halimov wants to merge 1 commit into
Open
fix(core/select): Make disabled prop work for select items #IX-4149#241dmytro-halimov wants to merge 1 commit into
dmytro-halimov wants to merge 1 commit into
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the select component by adding a description for disabled items. A review comment suggests rephrasing the new text to use active voice, refer to "users" in the plural, and avoid the Oxford comma, in alignment with the repository style guide.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ref: IX-4149
Main repo PR: siemens/ix#2567