fix: convert markdown dos and don's into ul with aria-label#243
Draft
nuke-ellington wants to merge 4 commits into
Draft
fix: convert markdown dos and don's into ul with aria-label#243nuke-ellington wants to merge 4 commits into
nuke-ellington wants to merge 4 commits into
Conversation
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several documentation files (.mdx) by converting markdown lists inside "dos-and-donts" container divs into semantic HTML unordered lists with appropriate "aria-label" attributes, and removing the "markdown" attributes from the container divs. The review feedback is highly accurate, pointing out multiple violations of the repository style guide where straight apostrophes (') were used instead of the required right single quotation mark (’).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
Dos and don'ts sections will not be distinguishable for screen readers
GitHub Issue Number: IX-4113
🆕 What is the new behavior?
👨💻 Help & support