fix(core/application): make sure force breakpoints takes effect#2571
fix(core/application): make sure force breakpoints takes effect#2571nuke-ellington wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 6005b97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ix-storybook canceled.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that the force-breakpoint property of ix-application takes effect dynamically if changed during runtime. It introduces a watcher for the property, refactors breakpoint assignment, and adds comprehensive Playwright component tests to verify initial rendering, runtime updates, and responsive detection re-enabling. However, a critical syntax error was identified in the HTML test app where optional chaining (?.) is used on the left-hand side of an assignment, which will cause a runtime parsing error.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
1 participant
💡 What is the current behavior?
Changing the forced breakpoints in
ix-applicationduring runtime did not have any effect on the layoutGitHub Issue Number: IX-4130
🆕 What is the new behavior?
forceBreakpointproperty will change the layout ofix-menuaccordingly🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support