feat(python): Add client for test results.#338
Merged
Conversation
2847096 to
8232130
Compare
b489647 to
7c26c80
Compare
bgfreeman7
reviewed
Oct 10, 2025
alexluck-sift
requested changes
Oct 11, 2025
Collaborator
|
Generally looks good, but please take a pass for consistency with the existing Resources. I called out some of these. Also: https://github.com/sift-stack/sift/blob/main/python/lib/sift_client/_internal/CONTRIBUTING.md |
Collaborator
|
An Idea to have consistency in namespacing and also clear differentiation between functions acting on different types would be to break these out into multiple "resources" within the same What do you think? class TestResultsStepsAPIAsync(ResourceBase):
def __init__(self, sift_client: SiftClient):
super().__init__(sift_client)
self._low_level_client = TestResultsLowLevelClient(
grpc_client=self.client.grpc_client
)
def create(self) -> TestStep: ...
def list_(self) -> list[TestStep]: ...
...
class TestResultsMeasurementsAPIAsync(ResourceBase):
def __init__(self, sift_client: SiftClient):
super().__init__(sift_client)
self._low_level_client = TestResultsLowLevelClient(
grpc_client=self.client.grpc_client
)
def create(self) -> Measurement: ...
def list_(self) -> list[Measurement]: ...
...
class TestResultsAPIAsync(ResourceBase):
def __init__(self, sift_client: SiftClient):
super().__init__(sift_client)
self._low_level_client = TestResultsLowLevelClient(
grpc_client=self.client.grpc_client
)
self._upload_client = UploadLowLevelClient(rest_client=self.client.rest_client)
self.steps = TestResultsStepsAPIAsync(self.client)
self.measurements = TestResultsMeasurementsAPIAsync(self.client)
def create(self) -> TestReport: ...
def list_(self) -> list[TestReport]: ...
...
# Usage
client = SiftClient(api_key="your_api_key")
test_result = client.test_results.create(...)
test_step = client.test_results.steps.create(...)
test_measurement = client.test_results.measurements.create(...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new integration test that exercises new client