Skip to content

feat(python): Add create_adhoc_run and utility function for stopping …#365

Merged
ian-sift merged 5 commits into
mainfrom
adhoc-runs-and-run-stop
Nov 6, 2025
Merged

feat(python): Add create_adhoc_run and utility function for stopping …#365
ian-sift merged 5 commits into
mainfrom
adhoc-runs-and-run-stop

Conversation

@ian-sift
Copy link
Copy Markdown
Contributor

@ian-sift ian-sift commented Nov 4, 2025

Verification: Updated test coverage

Confirmed run created by association had the the newly ingested flows on each associated assets
Screenshot 2025-11-04 at 12 18 55 PM

Confiremd adhoc run had data for given assets in time window
Screenshot 2025-11-04 at 12 19 40 PM

@ian-sift ian-sift force-pushed the adhoc-runs-and-run-stop branch from de39340 to 96fd3df Compare November 4, 2025 20:18
@ian-sift ian-sift force-pushed the adhoc-runs-and-run-stop branch from 96fd3df to c8a5493 Compare November 4, 2025 20:22
Comment thread python/lib/sift_client/resources/sync_stubs/__init__.pyi Outdated
@alexluck-sift
Copy link
Copy Markdown
Collaborator

I think we need to consider how adhoc runs and runs fit together. I don't think we have a great story of this in the UI as it is today and adding another point of confusiong by having two different create methods further cements the confusion.
Can we implement a single create function which can make either? What would the implications of that be?

@ian-sift
Copy link
Copy Markdown
Contributor Author

ian-sift commented Nov 4, 2025

I think we need to consider how adhoc runs and runs fit together. I don't think we have a great story of this in the UI as it is today and adding another point of confusiong by having two different create methods further cements the confusion. Can we implement a single create function which can make either? What would the implications of that be?

Only create_adhoc_run creates an adhoc run. The create_automatic_association_for_assets requires a run being created beforehand but could make it take all the same inputs as creating a run and manage creating the run then creating the association.

Comment thread python/lib/sift_client/resources/runs.py Outdated
Comment thread python/lib/sift_client/resources/runs.py Outdated
Comment thread python/lib/sift_client/resources/channels.py
Comment thread python/lib/sift_client/resources/runs.py
alexluck-sift
alexluck-sift previously approved these changes Nov 6, 2025
@ian-sift ian-sift merged commit 4f4246c into main Nov 6, 2025
15 checks passed
@ian-sift ian-sift deleted the adhoc-runs-and-run-stop branch November 6, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants