list_ refactor and docs fix#393
Merged
Merged
Conversation
alexluck-sift
commented
Nov 20, 2025
| show_symbol_type_heading: true | ||
| show_symbol_type_toc: true | ||
| summary: true | ||
| inherited_members: true |
Collaborator
Author
There was a problem hiding this comment.
This allows the mixin methods to show up (miss that we didn't have it enabled already)
alexluck-sift
commented
Nov 20, 2025
| filter_parts.append(cel.equals("file_name", file_name)) | ||
| filter_parts = [ | ||
| *self._build_name_cel_filters( | ||
| name=name, names=names, name_contains=name_contains, name_regex=name_regex |
Collaborator
Author
There was a problem hiding this comment.
this is much more flexible so users can leverage CEL without writing it
alexluck-sift
commented
Nov 20, 2025
| # *self._build_tags_metadata_cel_filters(metadata=metadata), | ||
| *self._build_common_cel_filters( | ||
| description_contains=description_contains, | ||
| filter_query=filter_query, |
Collaborator
Author
There was a problem hiding this comment.
as a fallback, users can also just write the CEL expression explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_to use generic filter patterns.