python(fix): Allow normal pagination for fetching data.#397
Closed
ian-sift wants to merge 7 commits into
Closed
Conversation
alexluck-sift
approved these changes
Nov 21, 2025
| start_time: datetime | None = None, | ||
| end_time: datetime | None = None, | ||
| limit: int | None = None, | ||
| max_results: int | None = None, |
Collaborator
There was a problem hiding this comment.
other resources used limit for the purpose, why change the arg name?
Contributor
Author
There was a problem hiding this comment.
i think the real issue here was the math i was doing w/ page size but was just a rush to unblock Gui. Opened a different PR to fix that and do things the same way we do for channels list #399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on a dataset w/ >10,000 points and was stuck at 10k before (channel data max page size). Now able to get ~150k for it