feat/updates for sift stream flow descriptor in sift stream bindings#405
Closed
tsift wants to merge 3 commits into
Closed
feat/updates for sift stream flow descriptor in sift stream bindings#405tsift wants to merge 3 commits into
tsift wants to merge 3 commits into
Conversation
8983a32 to
2302f6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates sift-stream to internally use the
FlowDescriptorinstead of holding onto theFlowConfigafter sending to Sift.IngestWithConfigDataStreamRequestis now persistent, performance formessage_to_ingest_reqactually improves a good amount, and even becoming more performant thanmessage_to_ingest_req_directat larger numbers of channels in the request.Updates to the sift-stream bindings and related Python client code to support the following APIs in sift-stream:
FlowDescriptorand relatedFlowBuilderto provide a more efficient method to generate ingestion requests.send_requests_nonblockingwhich removes async related overhead.This also removes the "get_config_flows" APIs, instead preferring users to use the
FlowDescriptorPyinstead.