-
Notifications
You must be signed in to change notification settings - Fork 8
python(feat): add progress indicators for job polling and file downlo… #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
609dbfd
python(feat): add progress indicators for job polling and file downlo…
wei-qlu ae67ac8
default to false for wait_and_download
wei-qlu bdfd304
added sync tests and updated polling details
wei-qlu 5fa1b1e
show_progress defaults to True for sync, False for async with global …
wei-qlu 2cbc58a
updated stubs
wei-qlu 27d881b
refactor to use a config dataclass singleton
wei-qlu c8af49d
add Config to __all__
wei-qlu 4742972
moved config to its own file
wei-qlu 71ff824
use slots to hide __setattr__ from autodocs, faster as well
wei-qlu 652b0f8
testing: updated filters for private
wei-qlu d4c0513
removed slots from config, slots requires 3.10+ but CI is running an …
wei-qlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| """Global configuration for the Sift client library.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from dataclasses import dataclass, fields | ||
|
|
||
|
|
||
| @dataclass | ||
| class Config: | ||
| """Global configuration for the Sift client library. | ||
|
|
||
| This is a singleton dataclass, use the module-level ``config`` instance | ||
| rather than creating your own:: | ||
|
|
||
| import sift_client | ||
|
|
||
| sift_client.config.show_progress = False | ||
|
|
||
| Setting an attribute that doesn't exist raises ``AttributeError`` so | ||
| typos are caught immediately. | ||
|
|
||
| """ | ||
|
|
||
| show_progress: bool | None = None | ||
| """Controls progress-bar display for job polling and file downloads. | ||
|
|
||
| ``None`` (default) shows bars for sync calls and hides them for async. | ||
| Set to ``False`` to disable everywhere. | ||
| """ | ||
|
|
||
| def __setattr__(self, name: str, value: object) -> None: | ||
| if name not in {f.name for f in fields(self)}: | ||
| raise AttributeError(f"Unknown setting: {name!r}") | ||
| super().__setattr__(name, value) | ||
|
|
||
|
|
||
| config = Config() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.