rust(feature): sift stream send api updates#519
Merged
Conversation
nathan-sift
requested changes
Mar 31, 2026
Contributor
nathan-sift
left a comment
nathan-sift
left a comment
There was a problem hiding this comment.
I like this approach. Only one comment
solidiquis
changed the title
solidiquis
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the sift_stream "send" APIs to have the following form:
Further, any messages not able to be send, either from a full or closed channel are returned to callers.
The python updates reflect the new API format of sift_stream, though at this time the Python return types do not allow for returning the messages back to the caller on failure -- this can be added in the future.